Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add heatmap to runs table [ET-230] #9429

Merged
merged 2 commits into from
May 29, 2024
Merged

Conversation

EmilyBonar
Copy link
Contributor

@EmilyBonar EmilyBonar commented May 28, 2024

Ticket

ET-230

Description

Adds heatmap to Flat Runs table

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@EmilyBonar EmilyBonar added the feature-flagged The changes in this PR are behind a feature flag label May 28, 2024
@EmilyBonar EmilyBonar requested a review from a team as a code owner May 28, 2024 16:12
@cla-bot cla-bot bot added the cla-signed label May 28, 2024
Copy link

netlify bot commented May 28, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit ce19d19
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/665772b035b85f0008f33de6
😎 Deploy Preview https://deploy-preview-9429--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented May 28, 2024

Codecov Report

Attention: Patch coverage is 0% with 232 lines in your changes are missing coverage. Please review.

Project coverage is 43.38%. Comparing base (cdd7a82) to head (ce19d19).
Report is 16 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9429      +/-   ##
==========================================
- Coverage   48.61%   43.38%   -5.23%     
==========================================
  Files        1233      909     -324     
  Lines      158972   119200   -39772     
  Branches     2778     2778              
==========================================
- Hits        77278    51718   -25560     
+ Misses      81520    67308   -14212     
  Partials      174      174              
Flag Coverage Δ
harness ?
web 44.29% <0.00%> (-0.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ebui/react/src/pages/FlatRuns/FlatRuns.settings.ts 0.00% <0.00%> (ø)
webui/react/src/pages/FlatRuns/columns.ts 0.00% <0.00%> (ø)
webui/react/src/pages/FlatRuns/FlatRuns.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

@johnkim-det
Copy link
Contributor

johnkim-det commented May 28, 2024

functionality looks good, still need to take a closer look at the code, but noticed a minor visual issue with tooltip alignment:
Screenshot 2024-05-28 at 5 52 10 PM

Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like this is missing the 'Apply'/'Cancel' heatmap option in header menus. Other than that and the tooltip issue, everything else looks good.

@EmilyBonar
Copy link
Contributor Author

functionality looks good, still need to take a closer look at the code, but noticed a minor visual issue with tooltip alignment: Screenshot 2024-05-28 at 5 52 10 PM

This is an pre-existing issue, it should be fixed by upgrading to antd 5.3.0. We're currently using 5.1.7. I support updating the library but it's out of scope for this PR.

Copy link
Contributor

@johnkim-det johnkim-det left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might wrap the Button in a Tooltip like we do in TableActionBar but I see the argument for using the tooltip prop and fixing the issue with it separately. everything else LGTM

@EmilyBonar EmilyBonar merged commit da2f943 into main May 29, 2024
84 of 97 checks passed
@EmilyBonar EmilyBonar deleted the emilybonar/runs-heatmap branch May 29, 2024 20:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed feature-flagged The changes in this PR are behind a feature flag
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants