Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: terraforming an EKS cluster with autoscaling and EFS. #9427

Merged
merged 3 commits into from
May 28, 2024
Merged

Conversation

ioga
Copy link
Contributor

@ioga ioga commented May 24, 2024

Description

Here's a "minimal" terraform code for setting up an EKS cluster with functional autoscaling for both aux and (nvidia) compute pools, plus an EFS for shared filesystem support.

It took me an embarrassing amount of time: EKS entities and terraform support for them are byzantine.

Fixes #9355

Test Plan

Try out the terraform example, if you dare.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 24, 2024
@determined-ci determined-ci requested a review from a team May 24, 2024 19:15
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 112fb1b
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6656119368d1c90008751147

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.59%. Comparing base (d4e23f4) to head (9e5c9d3).
Report is 29 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9427      +/-   ##
==========================================
- Coverage   46.07%   40.59%   -5.49%     
==========================================
  Files        1228      664     -564     
  Lines      155900    77614   -78286     
  Branches     2439        0    -2439     
==========================================
- Hits        71837    31507   -40330     
+ Misses      83872    46107   -37765     
+ Partials      191        0     -191     
Flag Coverage Δ
harness 37.93% <ø> (-26.14%) ⬇️
web ?

Flags with carried forward coverage won't be shown. Click here to find out more.

see 665 files with indirect coverage changes

@ioga ioga requested review from a team and kkunapuli and removed request for a team May 24, 2024 19:17
Copy link
Contributor

@kkunapuli kkunapuli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I really appreciate the comments in the terraform code.

@ioga ioga merged commit 58b31e6 into main May 28, 2024
15 of 64 checks passed
@ioga ioga deleted the eks-example branch May 28, 2024 17:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🤔[question] Open to updates to EKS deployment?
3 participants