Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add feature gate for checking for blank admin/determined password [DET-10197] #9425

Merged
merged 2 commits into from
May 24, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented May 24, 2024

Ticket

DET-10197

Description

Effectively removes service-side checking for blank passwords on default user accounts, by putting it behind a feature switch.

Test Plan

det deploy local commands etc. don't stall for up to 10 minutes

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@jesse-amano-hpe jesse-amano-hpe requested a review from a team as a code owner May 24, 2024 17:39
@jesse-amano-hpe jesse-amano-hpe requested a review from ioga May 24, 2024 17:39
@cla-bot cla-bot bot added the cla-signed label May 24, 2024
@determined-ci determined-ci requested a review from a team May 24, 2024 17:39
@determined-ci determined-ci added the documentation Improvements or additions to documentation label May 24, 2024
Copy link

netlify bot commented May 24, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f9f8c72
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6650d0d1f5d70a00082787e0

Copy link

codecov bot commented May 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 51.24%. Comparing base (3dfb9ec) to head (f9f8c72).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9425      +/-   ##
==========================================
- Coverage   51.24%   51.24%   -0.01%     
==========================================
  Files         746      746              
  Lines      110663   110663              
  Branches     2777     2777              
==========================================
- Hits        56713    56712       -1     
- Misses      53776    53777       +1     
  Partials      174      174              
Flag Coverage Δ
backend 34.23% <ø> (-0.05%) ⬇️
harness 64.02% <ø> (ø)
web 44.39% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@jesse-amano-hpe jesse-amano-hpe added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label May 24, 2024
@jesse-amano-hpe jesse-amano-hpe merged commit 684c38b into main May 24, 2024
108 of 122 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/feature-gate-password-check branch May 24, 2024 19:20
github-actions bot pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants