Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Keep template modal open when invalid #9424

Merged
merged 1 commit into from
May 24, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented May 24, 2024

Ticket

MD-427

Description

When editing/creating a template, if the config is not a valid json, throw an error and keep the modal open.

Test Plan

Create/edit a template with a valid yaml but invalid json config, for example a plain text.
There should be an error thrown, but the modal should keep open.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@gt2345 gt2345 requested a review from a team as a code owner May 24, 2024 17:27
@gt2345 gt2345 requested a review from ashtonG May 24, 2024 17:27
@cla-bot cla-bot bot added the cla-signed label May 24, 2024
Copy link

codecov bot commented May 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 43.44%. Comparing base (cdd7a82) to head (20888f0).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9424      +/-   ##
==========================================
- Coverage   48.61%   43.44%   -5.17%     
==========================================
  Files        1233      909     -324     
  Lines      158972   119049   -39923     
  Branches     2778     2777       -1     
==========================================
- Hits        77278    51718   -25560     
+ Misses      81520    67157   -14363     
  Partials      174      174              
Flag Coverage Δ
harness ?
web 44.39% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
.../react/src/pages/Templates/TemplateCreateModal.tsx 0.00% <0.00%> (ø)

... and 324 files with indirect coverage changes

@gt2345 gt2345 requested a review from hamidzr May 24, 2024 17:27
Copy link

netlify bot commented May 24, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 20888f0
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6650ce0d7d75f700087fa5f5
😎 Deploy Preview https://deploy-preview-9424--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@gt2345 gt2345 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label May 24, 2024
@gt2345 gt2345 merged commit 6ad9d73 into main May 24, 2024
84 of 107 checks passed
@gt2345 gt2345 deleted the gt/template-config-validation-fix branch May 24, 2024 18:19
github-actions bot pushed a commit that referenced this pull request May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants