-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: reset InteractiveTable pagination when filters applied [ET-183] [ET-121] #9413
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9413 +/- ##
==========================================
- Coverage 51.22% 43.99% -7.24%
==========================================
Files 747 423 -324
Lines 110720 70811 -39909
Branches 2778 2778
==========================================
- Hits 56718 31152 -25566
+ Misses 53827 39484 -14343
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think some of the places we're using InteractiveTable
already include a tableOffset
update in the handler passed to TableFilterDropdown
's onFilter
. Would making sure that all of those handlers include that update solve this issue? I think I'd prefer that approach if so.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
ET-183
ET-121
Description
There were pagination problems occurring in the following situation:
This ticket fixes the problem by resetting the table to the first page when filters are applied.
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.