Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin setuptools in model hub tests #9402

Merged
merged 1 commit into from
May 21, 2024
Merged

pin setuptools in model hub tests #9402

merged 1 commit into from
May 21, 2024

Conversation

azhou-determined
Copy link
Contributor

@azhou-determined azhou-determined commented May 21, 2024

Ticket

setuptools 70 is no longer compatible with older versions of torch/mmcv. pinning it for now.

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented May 21, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 1e8829f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/664d036100473a0008d7091c

Copy link

codecov bot commented May 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 48.20%. Comparing base (ce70c00) to head (1e8829f).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9402      +/-   ##
==========================================
+ Coverage   48.10%   48.20%   +0.09%     
==========================================
  Files        1219     1233      +14     
  Lines      157878   158671     +793     
  Branches     2731     2731              
==========================================
+ Hits        75954    76488     +534     
- Misses      81749    82008     +259     
  Partials      175      175              
Flag Coverage Δ
backend 42.03% <ø> (+<0.01%) ⬆️
harness 64.06% <ø> (+0.05%) ⬆️
web 43.50% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 17 files with indirect coverage changes

@azhou-determined azhou-determined requested a review from a team as a code owner May 21, 2024 20:17
Copy link
Contributor

@MikhailKardash MikhailKardash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@azhou-determined azhou-determined enabled auto-merge (squash) May 21, 2024 22:08
@azhou-determined azhou-determined merged commit 6ed2976 into main May 21, 2024
83 of 97 checks passed
@azhou-determined azhou-determined deleted the pin-setuptools branch May 21, 2024 22:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants