test: Remove flakiness of KillRun test #9370
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9370 +/- ##
=======================================
Coverage 45.28% 45.29%
=======================================
Files 1227 1227
Lines 154048 154048
Branches 2404 2404
=======================================
+ Hits 69767 69772 +5
+ Misses 84089 84084 -5
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
approved these changes
May 15, 2024
hamidzr
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
DET-10294
Description
Fix the flakiness of the kill run test by creating a new fixture that generates 4 runs with a deterministic hyperparameter and filter on that hyperparameter in the test. Addtionally we want to ensure that the experiment runs for long enough for the trials to be killed
Test Plan
e2e test should pass after multiple runs
4 runs with a distinct "unique_id" hyperparameter of 1, 2, 3 & 4
Checklist
docs/release-notes/.See Release Note for details.