feat: Flat Run Actions #9368
Merged
feat: Flat Run Actions #9368
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keita-determined
changed the title
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9368 +/- ##
==========================================
- Coverage 48.57% 43.29% -5.28%
==========================================
Files 1234 911 -323
Lines 158841 119262 -39579
Branches 2778 2779 +1
==========================================
- Hits 77155 51634 -25521
+ Misses 81511 67452 -14059
- Partials 175 176 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
keita-determined
force-pushed
the
feature/actions-flat-run-table
branch
2 times, most recently
from
faa104d to
7eee64d
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9368 +/- ##
==========================================
+ Coverage 49.79% 51.27% +1.47%
==========================================
Files 1247 1252 +5
Lines 162235 151993 -10242
Branches 2888 3018 +130
==========================================
- Hits 80793 77929 -2864
+ Misses 81270 73905 -7365
+ Partials 172 159 -13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
API doesnt not include |
keita-determined
force-pushed
the
feature/actions-flat-run-table
branch
5 times, most recently
from
20a458a to
f624a38
Compare
keita-determined
requested review from
gt2345,
hamidzr,
ashtonG,
corban-beaird and
AmanuelAaron
and removed request for
hamidzr and
gt2345
keita-determined
force-pushed
the
feature/actions-flat-run-table
branch
from
f624a38 to
763becb
Compare
keita-determined
force-pushed
the
feature/actions-flat-run-table
branch
from
763becb to
6919563
Compare
johnkim-det
reviewed
Jun 3, 2024
keita-determined
force-pushed
the
feature/actions-flat-run-table
branch
2 times, most recently
from
e87ef44 to
db64742
Compare
keita-determined
force-pushed
the
feature/actions-flat-run-table
branch
from
0fe119f to
f61cde3
Compare
fixed |
| Some runs you are trying to move belong to a Hyperparameter Search and cannot be moved | ||
| independently without breaking their contextual relationships. These runs will be moved with | ||
| their parent search. | ||
| {`Some of the runs you're trying to move are part of a hyperparameter search. To preserve their |
There was a problem hiding this comment.
to avoid "' can be escaped with ', ‘, ', ’." error, used string here
master/internal/api_runs.go
Outdated
| @@ -729,6 +732,11 @@ func archiveUnarchiveAction(ctx context.Context, archive bool, runIDs []int32, | |||
| for _, cand := range runCandidates { | |||
| visibleIDs.Insert(cand.ID) | |||
| switch { | |||
| case cand.ExpArchived: | |||
| results = append(results, &apiv1.RunActionResult{ | |||
| Error: "Run is part of archived Search.", | |||
There was a problem hiding this comment.
Would we be able to include what search it's part of?
corban-beaird
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
ET-110
Description
Flat Run Actions
TensorboardandPause/Unpauseactions are out of this PR, so not includedMoveaction will be implemented after #9390 is merged into thisTest Plan
archive,unarchive,delete,killactions are working with/without RBACChecklist
docs/release-notes/.See Release Note for details.