Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: rm test suite whose marks match no tests #9363

Merged
merged 2 commits into from
May 14, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented May 14, 2024

Ticket

Needs no ticket.

Description

This test suite hits no tests and wastes resources (money) spinning up a GKE cluster only to tear it down.

Test Plan

Is a test.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@stoksc stoksc requested a review from a team as a code owner May 14, 2024 01:13
@stoksc stoksc requested a review from dannysauer May 14, 2024 01:13
@cla-bot cla-bot bot added the cla-signed label May 14, 2024
Copy link

netlify bot commented May 14, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 293ff02
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6643eb973741ea0008ada3a6

@stoksc
Copy link
Contributor Author

stoksc commented May 14, 2024

@MikhailKardash figured you would know if this is a bug (we meant to be testing stuff here) or we removed these tests and forgot to remove the suite. My opinion is that we can't possibly need this suite.

Copy link

codecov bot commented May 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.24%. Comparing base (68b7116) to head (293ff02).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9363      +/-   ##
==========================================
- Coverage   45.28%   45.24%   -0.05%     
==========================================
  Files        1227     1227              
  Lines      154048   154048              
  Branches     2404     2403       -1     
==========================================
- Hits        69765    69692      -73     
- Misses      84091    84164      +73     
  Partials      192      192              
Flag Coverage Δ
backend 41.76% <ø> (+0.01%) ⬆️
harness 63.88% <ø> (-0.20%) ⬇️
web 36.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 8 files with indirect coverage changes

@dannysauer dannysauer changed the title chore: rm test suite whose marks match not tests chore: rm test suite whose marks match no tests May 14, 2024
@stoksc stoksc assigned dannysauer and unassigned MikhailKardash May 14, 2024
Copy link
Contributor

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@stoksc stoksc merged commit 3b1d0df into main May 14, 2024
65 of 93 checks passed
@stoksc stoksc deleted the rm-test-e2e-gke-single-gpu-tfonly branch May 14, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants