-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: rm test suite whose marks match no tests #9363
Conversation
✅ Deploy Preview for determined-ui canceled.
|
@MikhailKardash figured you would know if this is a bug (we meant to be testing stuff here) or we removed these tests and forgot to remove the suite. My opinion is that we can't possibly need this suite. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9363 +/- ##
==========================================
- Coverage 45.28% 45.24% -0.05%
==========================================
Files 1227 1227
Lines 154048 154048
Branches 2404 2403 -1
==========================================
- Hits 69765 69692 -73
- Misses 84091 84164 +73
Partials 192 192
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Ticket
Needs no ticket.
Description
This test suite hits no tests and wastes resources (money) spinning up a GKE cluster only to tear it down.
Test Plan
Is a test.
Checklist
docs/release-notes/
.See Release Note for details.