Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix circleci gke tests with helm password [DET-10196] #9361

Merged
merged 2 commits into from
May 14, 2024

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented May 13, 2024

Ticket

DET-10196

Description

Fixes CircleCI issues introduced by #9359 .

Test Plan

N/A

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label May 13, 2024
Copy link

netlify bot commented May 13, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d434577
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6642b15016b5910008d9f323

Copy link

codecov bot commented May 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.16%. Comparing base (0941fc4) to head (d434577).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9361      +/-   ##
==========================================
+ Coverage   45.14%   45.16%   +0.01%     
==========================================
  Files        1230     1230              
  Lines      154472   154472              
  Branches     2404     2404              
==========================================
+ Hits        69737    69765      +28     
+ Misses      84540    84512      -28     
  Partials      195      195              
Flag Coverage Δ
backend 41.80% <ø> (+0.05%) ⬆️
harness 64.07% <ø> (ø)
web 36.05% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@jesse-amano-hpe jesse-amano-hpe changed the title fix: circleci gke test with helm [DET-10196] test: fix circleci gke tests with helm password [DET-10196] May 14, 2024
@stoksc stoksc marked this pull request as ready for review May 14, 2024 01:05
@stoksc stoksc requested a review from a team as a code owner May 14, 2024 01:05
@stoksc stoksc requested a review from djanicekpach May 14, 2024 01:05
@stoksc
Copy link
Contributor

stoksc commented May 14, 2024

lgtm. we're good to merge this as soon as it's clear python in tests is authing to the deployments correctly.

@stoksc
Copy link
Contributor

stoksc commented May 14, 2024

gonna land over the efs test--definitely not related and this fixes all the gke tests on main.

@stoksc stoksc closed this May 14, 2024
@stoksc
Copy link
Contributor

stoksc commented May 14, 2024

urgh hit the wrong button

@stoksc stoksc reopened this May 14, 2024
@stoksc stoksc merged commit 8c5fce7 into main May 14, 2024
101 of 112 checks passed
@stoksc stoksc deleted the jta/DET-10293/fix-ci branch May 14, 2024 01:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants