-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: fix circleci gke tests with helm password [DET-10196] #9361
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9361 +/- ##
==========================================
+ Coverage 45.14% 45.16% +0.01%
==========================================
Files 1230 1230
Lines 154472 154472
Branches 2404 2404
==========================================
+ Hits 69737 69765 +28
+ Misses 84540 84512 -28
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
lgtm. we're good to merge this as soon as it's clear python in tests is authing to the deployments correctly. |
gonna land over the efs test--definitely not related and this fixes all the gke tests on main. |
urgh hit the wrong button |
Ticket
DET-10196
Description
Fixes CircleCI issues introduced by #9359 .
Test Plan
N/A
Checklist
docs/release-notes/
.See Release Note for details.