Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: rename getRM for multiRM to more intuitive name #9350

Merged
merged 1 commit into from
May 16, 2024

Conversation

amandavialva01
Copy link
Contributor

@amandavialva01 amandavialva01 commented May 10, 2024

Ticket

DET-10289

Description

Currently, getRM only returns the name of the desired resource manager, rather than the resource manager itself. Rename this to getRMName so that getRM can be implemented to retrieve the desired resource manager, as its function name suggests.

Ref here, where we use getRM to return the resource manager needed to provision resources within its corresponding cluster.

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@amandavialva01 amandavialva01 requested a review from a team as a code owner May 10, 2024 15:19
@cla-bot cla-bot bot added the cla-signed label May 10, 2024
Copy link

netlify bot commented May 10, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 4cb3bb7
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66464056d33acf0008d39cf0

Copy link

codecov bot commented May 10, 2024

Codecov Report

Attention: Patch coverage is 86.95652% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 45.14%. Comparing base (c3901c8) to head (4cb3bb7).
Report is 23 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9350      +/-   ##
==========================================
- Coverage   45.16%   45.14%   -0.03%     
==========================================
  Files        1230     1230              
  Lines      154567   154567              
  Branches     2405     2405              
==========================================
- Hits        69817    69782      -35     
- Misses      84555    84590      +35     
  Partials      195      195              
Flag Coverage Δ
backend 41.75% <86.95%> (-0.07%) ⬇️
harness 64.07% <ø> (ø)
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/rm/multirm/multirm.go 83.33% <86.95%> (ø)

... and 5 files with indirect coverage changes

@amandavialva01 amandavialva01 merged commit 31bc08a into main May 16, 2024
83 of 96 checks passed
@amandavialva01 amandavialva01 deleted the amanda/renameGetRM branch May 16, 2024 19:07
@amandavialva01 amandavialva01 changed the title refactor: rename multiRM to more intuitive name refactor: rename getRM for multiRM to more intuitive name May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants