fix: remove pod labels with potentially incompatible names #9349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
kkunapuli
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9349 +/- ##
==========================================
+ Coverage 45.16% 46.49% +1.33%
==========================================
Files 1230 743 -487
Lines 154572 106597 -47975
Branches 2404 2405 +1
==========================================
- Hits 69812 49566 -20246
+ Misses 84565 56836 -27729
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
stoksc
approved these changes
May 10, 2024
|
|
||
| **Bug Fixes** | ||
|
|
||
| - Kubernetes: Remove pod labels that could have characters incompatible with Kubernetes naming requirements. This change will not affect Determined functionality. |
There was a problem hiding this comment.
I would ignore the cause of the issue and just describe the issue
Something like
Fix an issue introduced in 0.32.0 where workspaces with names incompatible with Kubernetes naming requirements would cause jobs in that workspace to fail.
NicholasBlaskey
approved these changes
May 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
RM-278
Description
Test Plan
Checklist
docs/release-notes/.See Release Note for details.