chore: update codecov to ignore e2e react [INFENG-689] #9346
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9346 +/- ##
==========================================
- Coverage 45.15% 45.14% -0.01%
==========================================
Files 1230 1230
Lines 154523 154523
Branches 2405 2404 -1
==========================================
- Hits 69772 69766 -6
- Misses 84556 84562 +6
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
JComins000
force-pushed
the
jcom/INFENG-689/remove-e2e-from-codecov
branch
from
265f779 to
1bbd2a0
Compare
JComins000
commented
May 9, 2024
| @@ -40,6 +40,3 @@ comment: | |||
| parsers: | |||
| go: | |||
| partials_as_hits: true | |||
|
|
|||
There was a problem hiding this comment.
this was from my change yesterday. it didn't help with anything
JComins000
commented
May 9, 2024
| @@ -27,7 +27,7 @@ | |||
| "format-check:misc": "prettier --check \"src/**/*.{md,json}\"", | |||
| "test": "vitest", | |||
| "e2e": "playwright test", | |||
| "test:coverage": "vitest --run --coverage --silent --exclude \"src/e2e/tests/**\"", | |||
| "test:coverage": "vitest --run --coverage --silent", | |||
There was a problem hiding this comment.
this wasn't working either, so i removed it
bitfyre
approved these changes
May 9, 2024
ashtonG
approved these changes
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket
INFENG-689
Description
removes e2e from vite codecov config
Test Plan
e2e not showing up here
Checklist
docs/release-notes/.See Release Note for details.