-
Notifications
You must be signed in to change notification settings - Fork 363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: log in with the api rather than through the UI for most react tests #9307
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9307 +/- ##
==========================================
- Coverage 44.59% 37.90% -6.69%
==========================================
Files 1275 952 -323
Lines 156478 116717 -39761
Branches 2449 2450 +1
==========================================
- Hits 69777 44244 -25533
+ Misses 86461 72232 -14229
- Partials 240 241 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this looks pretty good! i guess we didn't change user spec yet. maybe in the future we can use swagger codegen
990a0d9
to
eb4d44c
Compare
test: log in with the api rather than through the UI for most react tests
Ticket
infeng-671
Description
Previously for all our tests we logged in by navigating to the UI and logging in. It will be faster and have less code to just auto-login through the API and apply the cookie to the browser.
More stuff coming in user management with the next ticket, but this is a self-contained start.
Test Plan
ran manually and CI should pass.
Checklist
docs/release-notes/
.See Release Note for details.