Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: circleci slack alerts should go to #ci-bots #9300

Merged
merged 1 commit into from
May 3, 2024
Merged

Conversation

ioga
Copy link
Contributor

@ioga ioga commented May 2, 2024

Description

After EE merge the Slack alerts ended up being configured to go to #ci-bots-ee which is archived and did not work.

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@ioga ioga requested a review from a team as a code owner May 2, 2024 23:42
@ioga ioga requested a review from djanicekpach May 2, 2024 23:42
@cla-bot cla-bot bot added the cla-signed label May 2, 2024
Copy link

netlify bot commented May 2, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 860bbb4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663424e916934a0008c303fb

Copy link

codecov bot commented May 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 44.61%. Comparing base (abcc7b4) to head (860bbb4).
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9300      +/-   ##
==========================================
- Coverage   44.63%   44.61%   -0.02%     
==========================================
  Files        1274     1275       +1     
  Lines      156005   156240     +235     
  Branches     2447     2450       +3     
==========================================
+ Hits        69629    69713      +84     
- Misses      86137    86287     +150     
- Partials      239      240       +1     
Flag Coverage Δ
backend 41.80% <ø> (+0.04%) ⬆️
harness 64.08% <ø> (-0.02%) ⬇️
web 35.04% <ø> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@ioga ioga merged commit 9357391 into main May 3, 2024
87 of 100 checks passed
@ioga ioga deleted the ci-bots-channel branch May 3, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants