-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: helm requires bootstrap password (DET-10196) #9274
feat: helm requires bootstrap password (DET-10196) #9274
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9274 +/- ##
=======================================
Coverage 45.13% 45.13%
=======================================
Files 1230 1230
Lines 154523 154523
Branches 2405 2404 -1
=======================================
+ Hits 69740 69743 +3
+ Misses 84588 84585 -3
Partials 195 195
Flags with carried forward coverage won't be shown. Click here to find out more. |
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
**Breaking Changes** | ||
|
||
- Helm: a ``initialUserPassword`` entry is now required; see :ref:`Helm Chart | ||
<helm-config-reference>` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:orphan:
Breaking Changes
- Helm: An entry for
initialUserPassword
is now required. See :ref:Helm Chart <helm-config-reference>
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggested edits
7400abf
to
e0cf4a4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm modulo adding a slightly nicer message in the values.yaml (that's the only documentation i read, personally)
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jesse-amano-hpe on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla. After we approve your CLA, we will update the contributors list (private) and comment |
7c2c6d5
to
d8083e4
Compare
Co-authored-by: tara-det-ai <[email protected]>
d8083e4
to
f88fa0b
Compare
Ticket
DET-10196
Description
BREAKING CHANGE: Helm now requires setting a bootstrap password for the admin and determined users via the
initialUserPassword
entry.This is a fairly simple and straightforward change, and most of our existing documentation around this entry already indicates that it's required.
Test Plan
Attempting to run a helm deployment without adding an
initialUserPassword
entry should fail.Checklist
docs/release-notes/
.See Release Note for details.