Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: helm requires bootstrap password (DET-10196) #9274

Merged

Conversation

jesse-amano-hpe
Copy link
Contributor

@jesse-amano-hpe jesse-amano-hpe commented Apr 30, 2024

Ticket

DET-10196

Description

BREAKING CHANGE: Helm now requires setting a bootstrap password for the admin and determined users via the initialUserPassword entry.

This is a fairly simple and straightforward change, and most of our existing documentation around this entry already indicates that it's required.

Test Plan

Attempting to run a helm deployment without adding an initialUserPassword entry should fail.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 30, 2024
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.13%. Comparing base (cc82cc9) to head (1216aa3).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #9274   +/-   ##
=======================================
  Coverage   45.13%   45.13%           
=======================================
  Files        1230     1230           
  Lines      154523   154523           
  Branches     2405     2404    -1     
=======================================
+ Hits        69740    69743    +3     
+ Misses      84588    84585    -3     
  Partials      195      195           
Flag Coverage Δ
backend 41.71% <ø> (+<0.01%) ⬆️
harness 64.09% <ø> (ø)
web 36.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@determined-ci determined-ci requested a review from a team April 30, 2024 23:22
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 30, 2024
Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 1216aa3
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663bf2d17663ea0008366ed8
😎 Deploy Preview https://deploy-preview-9274--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

**Breaking Changes**

- Helm: a ``initialUserPassword`` entry is now required; see :ref:`Helm Chart
<helm-config-reference>`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:orphan:

Breaking Changes

  • Helm: An entry for initialUserPassword is now required. See :ref:Helm Chart <helm-config-reference>.

Copy link
Contributor

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edits

@jesse-amano-hpe jesse-amano-hpe requested review from stoksc and a team May 1, 2024 17:34
@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/DET-10196/helm-requires-bootstrap-password branch from 7400abf to e0cf4a4 Compare May 1, 2024 17:40
@jesse-amano-hpe jesse-amano-hpe enabled auto-merge (squash) May 1, 2024 18:43
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm modulo adding a slightly nicer message in the values.yaml (that's the only documentation i read, personally)

@jesse-amano-hpe jesse-amano-hpe enabled auto-merge (squash) May 6, 2024 18:23
helm/charts/determined/values.yaml Outdated Show resolved Hide resolved
Copy link

cla-bot bot commented May 7, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jesse-amano-hpe on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@cla-bot cla-bot bot removed the cla-signed label May 7, 2024
@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/DET-10196/helm-requires-bootstrap-password branch from 7c2c6d5 to d8083e4 Compare May 8, 2024 21:41
@cla-bot cla-bot bot added the cla-signed label May 8, 2024
@jesse-amano-hpe jesse-amano-hpe force-pushed the jta/DET-10196/helm-requires-bootstrap-password branch from d8083e4 to f88fa0b Compare May 8, 2024 21:46
@jesse-amano-hpe jesse-amano-hpe enabled auto-merge (squash) May 8, 2024 21:47
@jesse-amano-hpe jesse-amano-hpe enabled auto-merge (squash) May 8, 2024 21:48
@jesse-amano-hpe jesse-amano-hpe enabled auto-merge (squash) May 8, 2024 21:48
@jesse-amano-hpe jesse-amano-hpe merged commit 0a0b3c3 into main May 9, 2024
84 of 97 checks passed
@jesse-amano-hpe jesse-amano-hpe deleted the jta/DET-10196/helm-requires-bootstrap-password branch May 9, 2024 16:08
jesse-amano-hpe added a commit that referenced this pull request May 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants