Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: try to fix slurm podman tests by not building agent binary #9273

Merged
merged 2 commits into from
May 1, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Apr 30, 2024

Ticket

Description

Fix failing podman tests not fixed by #9267

Avoid building and packaging the agent again, just use the one built in build-go

Test Plan

test passes on main after

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c8c9af1
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/663158246f55da00089381c3

Copy link

netlify bot commented Apr 30, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit c2aa992
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6631582ebce60200084ae27f

Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.64%. Comparing base (ae91042) to head (c2aa992).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9273      +/-   ##
==========================================
+ Coverage   44.62%   45.64%   +1.02%     
==========================================
  Files        1273      786     -487     
  Lines      155894   108102   -47792     
  Branches     2439     2439              
==========================================
- Hits        69561    49344   -20217     
+ Misses      86094    58519   -27575     
  Partials      239      239              
Flag Coverage Δ
backend 34.27% <ø> (-7.48%) ⬇️
harness 63.90% <ø> (-0.20%) ⬇️
web 35.04% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 491 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey merged commit 6bd2a8c into main May 1, 2024
83 of 99 checks passed
@NicholasBlaskey NicholasBlaskey deleted the round_2_podman_fix branch May 1, 2024 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants