Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: report errors from deletecheckpoints endpoint + improve feedback #9178

Merged
merged 4 commits into from
Apr 17, 2024

fix patchcheckpoints too

4c8434f
Select commit
Loading
Failed to load commit list.
Merged

fix: report errors from deletecheckpoints endpoint + improve feedback #9178

fix patchcheckpoints too
4c8434f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Apr 17, 2024 in 0s

37.10% (-8.61%) compared to 3f70a46

View this Pull Request on Codecov

37.10% (-8.61%) compared to 3f70a46

Details

Codecov Report

Attention: Patch coverage is 39.39394% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 37.10%. Comparing base (3f70a46) to head (4c8434f).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9178      +/-   ##
==========================================
- Coverage   45.71%   37.10%   -8.61%     
==========================================
  Files        1179      600     -579     
  Lines      146795    93617   -53178     
  Branches     2419     2420       +1     
==========================================
- Hits        67110    34741   -32369     
+ Misses      79471    58662   -20809     
  Partials      214      214              
Files Coverage Δ
webui/react/src/services/apiConfig.ts 72.65% <100.00%> (+0.13%) ⬆️
webui/react/src/services/api.ts 0.00% <0.00%> (ø)
webui/react/src/components/CheckpointModal.tsx 19.90% <12.50%> (-0.92%) ⬇️
.../pages/ExperimentDetails/ExperimentCheckpoints.tsx 13.59% <12.50%> (-0.46%) ⬇️

... and 665 files with indirect coverage changes