Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: style fix for helm tls #9163

Merged
merged 1 commit into from
Apr 15, 2024
Merged

chore: style fix for helm tls #9163

merged 1 commit into from
Apr 15, 2024

Conversation

amandavialva01
Copy link
Contributor

Ticket

No ticket for this.

Description

Fix helm style for master tls config

Test Plan

CI passes.

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.71%. Comparing base (8a94574) to head (f5782a9).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9163      +/-   ##
==========================================
- Coverage   45.72%   45.71%   -0.02%     
==========================================
  Files        1179     1179              
  Lines      146795   146795              
  Branches     2420     2419       -1     
==========================================
- Hits        67123    67106      -17     
- Misses      79458    79475      +17     
  Partials      214      214              
Flag Coverage Δ
backend 43.73% <ø> (-0.04%) ⬇️
harness 64.02% <ø> (-0.01%) ⬇️
web 35.82% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

Copy link

netlify bot commented Apr 15, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f5782a9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/661d3216f583970008f0b356

@amandavialva01 amandavialva01 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 15, 2024
Copy link
Contributor

@salonig23 salonig23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@salonig23 salonig23 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@amandavialva01 amandavialva01 merged commit 3f70a46 into main Apr 15, 2024
78 of 92 checks passed
@amandavialva01 amandavialva01 deleted the amanda/fixHelmStyle branch April 15, 2024 14:42
dai-release bot pushed a commit that referenced this pull request Apr 15, 2024
kkunapuli pushed a commit that referenced this pull request Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants