Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix disable button condition in launch jupyter notebook modal #9155

Merged
merged 1 commit into from
Apr 12, 2024

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Apr 11, 2024

Ticket

MD-360

Description

Follow up of #9109

Test Plan

  • Check if launch button is enabled when all required fields are filled
  • Check if launch button is disabled when one or more required fields are missing

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 11, 2024
@keita-determined keita-determined marked this pull request as ready for review April 11, 2024 23:43
@keita-determined keita-determined requested a review from a team as a code owner April 11, 2024 23:43
Copy link

netlify bot commented Apr 11, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 902f36f
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6618759271981d00072dda33
😎 Deploy Preview https://deploy-preview-9155--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined requested a review from gt2345 April 11, 2024 23:43
Copy link

codecov bot commented Apr 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.99%. Comparing base (b109108) to head (902f36f).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9155      +/-   ##
==========================================
- Coverage   45.71%   38.99%   -6.72%     
==========================================
  Files        1179      857     -322     
  Lines      146790   107388   -39402     
  Branches     2419     2420       +1     
==========================================
- Hits        67104    41879   -25225     
+ Misses      79472    65295   -14177     
  Partials      214      214              
Flag Coverage Δ
harness ?
web 35.82% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
webui/react/src/components/JupyterLabModal.tsx 84.42% <100.00%> (+0.06%) ⬆️

... and 322 files with indirect coverage changes

@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 11, 2024
@keita-determined keita-determined merged commit 384e5c0 into main Apr 12, 2024
78 of 90 checks passed
@keita-determined keita-determined deleted the fix/jupyternb-button branch April 12, 2024 16:42
dai-release bot pushed a commit that referenced this pull request Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants