Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix docs for log retention #9149

Merged
merged 1 commit into from
Apr 11, 2024
Merged

fix: fix docs for log retention #9149

merged 1 commit into from
Apr 11, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Apr 11, 2024 •
edited
Loading

Ticket

Description

Docs had the wrong command det master cleanup-logs. Changed it to det task cleanup-logs

Test Plan

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

@cla-bot cla-bot bot added the cla-signed label Apr 11, 2024
@salonig23 salonig23 requested a review from tara-hpe April 11, 2024 15:36
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Apr 11, 2024
@determined-ci determined-ci requested a review from a team April 11, 2024 15:36
@netlify Netlify
Copy link

netlify bot commented Apr 11, 2024 •
edited
Loading

✅ Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 80fbe6e
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6618083294025500085eebe1

@salonig23 salonig23 marked this pull request as ready for review April 11, 2024 15:37
@salonig23 salonig23 added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Apr 11, 2024
tara-hpe
tara-hpe approved these changes Apr 11, 2024
View reviewed changes
Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@salonig23 salonig23 merged commit d0497da into main Apr 11, 2024
71 of 83 checks passed
@salonig23 salonig23 deleted the fix-docs-release branch April 11, 2024 16:24
dai-release bot pushed a commit that referenced this pull request Apr 11, 2024
@salonig23 @determined-ci
fix: fix docs for log retention (#9149)
7f7d2bf 
(cherry picked from commit d0497da)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tara-hpe tara-hpe tara-hpe approved these changes

Assignees
No one assigned
Labels
cla-signed documentation Improvements or additions to documentation to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@salonig23 @tara-hpe @determined-ci