-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: ensure all columns have widths #9136
Conversation
this is an alternate fix for a bug where updating the compare width would cause the experiment list settings to be in an invalid state. It seems like the issue was due to settings widths not containing pinned columns, so we try to update the column widths along with the columns when they update.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9136 +/- ##
==========================================
- Coverage 46.16% 39.52% -6.64%
==========================================
Files 1174 852 -322
Lines 145187 105835 -39352
Branches 2413 2413
==========================================
- Hits 67025 41832 -25193
+ Misses 77954 63795 -14159
Partials 208 208
Flags with carried forward coverage won't be shown. Click here to find out more.
|
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@EmilyBonar we avoid adjusting the column widths below the minimum width when adjusting the comparison width, but it seems we don't do that when adjusting the column size itself -- i just pushed a fix for that -- can you verify? |
Yes, that seems to be working. I'm still seeing the shadow shown in the previous screenshot though. |
i think the shadow might be tied to the split pane component and how it throttles the size changes. Can we make that its own issue please? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
(cherry picked from commit 95f87d7)
Ticket
ET-161
Description
this is an alternate fix for a bug where updating the compare width would cause the experiment list settings to be in an invalid state. It seems like the issue was due to settings widths not containing pinned columns, so we try to update the column widths along with the columns when they update.
Test Plan
Checklist
docs/release-notes/
.See Release Note for details.