-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add custom key to projects table, backfilling based on current project name, and API support #9134
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9134 +/- ##
==========================================
+ Coverage 48.96% 48.99% +0.02%
==========================================
Files 1234 1235 +1
Lines 159823 160128 +305
Branches 2781 2780 -1
==========================================
+ Hits 78264 78454 +190
- Misses 81384 81499 +115
Partials 175 175
Flags with carried forward coverage won't be shown. Click here to find out more.
|
b30f36e
to
23446b9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall.
master/static/migrations/20240409104254_add-custom-project-key.tx.up.sql
Outdated
Show resolved
Hide resolved
21c95ba
to
a165316
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we plan to allow changing project key after creation? My concern is that, it's possible that the generated key is an annoying/racist word, and the user might want to change that
master/static/migrations/20240508154139_add-custom-project-key.tx.up.sql
Outdated
Show resolved
Hide resolved
a165316
to
f9563a8
Compare
fdabe47
to
059bb91
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Working as expected when testing on CLI, just a few questions
…ck on duplicate project name
… testing, adjust transaction isolation level
bd97020
to
141ee7f
Compare
Ticket
ET-97
ET-101
ET-102
ET-164
Description
Introduce custom project key (similar to JIRA's project key), to be able to refer to projects. This adds the column to the DB & backfills existing projects based on their existing project name.
This also includes allowing the key to be specified in the
CreateProject
endpoint (PostProject).Test Plan
Checklist
docs/release-notes/
.See Release Note for details.
Commentary
Work will need to be done to allow updating project keys of existing projects (that is being handled in ET-98). This will likely include updating the logic for how we determine uniqueness, since the requirement will need to ensure no past project keys had been in use.