Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: INFENG-600 remove single commit legacy validation #9104

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

JComins000
Copy link
Contributor

Description

INFENG-600
Removed the validation on single commits. It was a legacy feature anyway.
https://github.com/amannn/action-semantic-pull-request?tab=readme-ov-file#legacy-configuration-for-validating-single-commits

Test Plan

The config is on pull_request_target, so we can't test this change until it hits main.

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@JComins000 JComins000 requested a review from a team as a code owner April 3, 2024 22:37
@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 39ab153
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660dda86cc989c000714ede0

@JComins000 JComins000 force-pushed the jcom/INFENG-600/PR-validation branch from 0d58959 to 39ab153 Compare April 3, 2024 22:39
@JComins000 JComins000 changed the title Jcom/infeng 600/pr validation feat: INFENG-600 remove single commit legacy validation Apr 3, 2024
@dannysauer dannysauer changed the title feat: INFENG-600 remove single commit legacy validation ci: INFENG-600 remove single commit legacy validation Apr 3, 2024
Copy link
Contributor

@dannysauer dannysauer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In conjunction with changing the default Squash Merge commit message to always be PR title, this is a good change.

@dannysauer dannysauer merged commit 58cd22b into main Apr 3, 2024
61 of 77 checks passed
@dannysauer dannysauer deleted the jcom/INFENG-600/PR-validation branch April 3, 2024 22:43
@dannysauer
Copy link
Contributor

Merged without waiting for CI since there's no reason to run Det end-to-end tests on this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants