Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: change RM log message back to Debug level #9093

Merged
merged 1 commit into from
Apr 3, 2024

Conversation

carolinaecalderon
Copy link
Contributor

Description

Accidentally overwrote this in RM-123,
, but the log should be at debug level.

Test Plan

N/A

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Apr 3, 2024
Copy link

codecov bot commented Apr 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.32%. Comparing base (3688c3f) to head (e175fcc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9093      +/-   ##
==========================================
- Coverage   48.48%   47.32%   -1.16%     
==========================================
  Files         738     1128     +390     
  Lines      102297   140107   +37810     
  Branches     2423     2421       -2     
==========================================
+ Hits        49598    66307   +16709     
- Misses      52509    73610   +21101     
  Partials      190      190              
Flag Coverage Δ
backend 43.58% <100.00%> (+9.37%) ⬆️
harness 64.07% <ø> (-0.01%) ⬇️
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/rm/multirm/multirm.go 83.33% <100.00%> (ø)

... and 446 files with indirect coverage changes

@carolinaecalderon carolinaecalderon marked this pull request as ready for review April 3, 2024 17:07
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner April 3, 2024 17:07
Copy link

netlify bot commented Apr 3, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e175fcc
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660d8ce66fc483000892f7fb

@carolinaecalderon carolinaecalderon merged commit d4eed0e into main Apr 3, 2024
75 of 87 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/rm-123 branch April 3, 2024 18:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants