Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add change in master config to devcluster.yaml #9087

Merged
merged 1 commit into from
Apr 2, 2024

Conversation

salonig23
Copy link
Contributor

Description

added change in master config to devcluster.yaml

Test Plan

run devcluster locally and make sure there are no errors

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Apr 2, 2024
Copy link

netlify bot commented Apr 2, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit f45c8c4
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/660c52a9f2c30f0008e1d299
😎 Deploy Preview https://deploy-preview-9087--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@salonig23 salonig23 marked this pull request as ready for review April 2, 2024 18:48
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, probably make this a "chore: ..." just so release party doesn't need to test it

Copy link

codecov bot commented Apr 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 42.76%. Comparing base (1a38f0c) to head (f45c8c4).
Report is 11 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9087      +/-   ##
==========================================
- Coverage   47.06%   42.76%   -4.31%     
==========================================
  Files        1154      709     -445     
  Lines      142372   100500   -41872     
  Branches     2423     2421       -2     
==========================================
- Hits        67005    42976   -24029     
+ Misses      75177    57334   -17843     
  Partials      190      190              
Flag Coverage Δ
backend 34.24% <ø> (-8.66%) ⬇️
harness 49.47% <ø> (-14.60%) ⬇️
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 583 files with indirect coverage changes

@salonig23 salonig23 changed the title fix: add change in master config to devcluster.yaml chore: add change in master config to devcluster.yaml Apr 2, 2024
@salonig23 salonig23 merged commit f78b9aa into main Apr 2, 2024
69 of 85 checks passed
@salonig23 salonig23 deleted the fix-devcluster branch April 2, 2024 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants