chore: change log level for multirm messages [RM-125] #9080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9080 +/- ##
==========================================
- Coverage 47.06% 47.06% -0.01%
==========================================
Files 1154 1154
Lines 142374 142374
Branches 2423 2423
==========================================
- Hits 67009 67005 -4
- Misses 75175 75179 +4
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. |
NicholasBlaskey
approved these changes
Apr 1, 2024
| @@ -378,7 +378,7 @@ func (m *MultiRMRouter) DisableSlot(req *apiv1.DisableSlotRequest) (*apiv1.Disab | |||
| func (m *MultiRMRouter) getRM(rpName rm.ResourcePoolName) (string, error) { | |||
| // If not given RP name, route to default RM. | |||
| if rpName == "" { | |||
| m.syslog.Infof("RM undefined, routing to default resource manager") | |||
| m.syslog.Debugf("RM undefined, routing to default resource manager") | |||
There was a problem hiding this comment.
maybe would change the title of the PR to chore: ...
so release party doesn't need to test this
carolinaecalderon
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Change the multirm logs from info level to debug level
Test Plan
Start a new experiment, on a multiRM cluster & define it to run on a resource pool 'XYZ' (or whatever other name). Then, after starting the experiment, check that your logs contain
DEBU[2024-04-01T13:28:57-04:00] RM defined as <the-rm-name-where-the-pool-lives>, <the-pool-name> component=resource-routerIf you test with a pool/pool name that doesn't exist, then you should see the default RM and pool name being used, with the message at the debug level.
If you test with a blank pool name (so don't define a resource pool in your experiment yaml), you should see "RM undefined, routing to default resource manager" at the debug level.
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket
RM-125