Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: agent level check if slotstats are computed at rm level #9073

Merged
merged 1 commit into from
Mar 29, 2024

Conversation

hamidzr
Copy link
Contributor

@hamidzr hamidzr commented Mar 29, 2024

(cherry picked from commit 370ef81d2eecf8971a49d6a77c4c84b4cd2c51e9)
safety net just in case one of the RM's doesn't include the summaries

Description

Test Plan

Commentary (optional)

https://github.com/determined-ai/determined-ee/pull/1227

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

(cherry picked from commit 370ef81d2eecf8971a49d6a77c4c84b4cd2c51e9)
@hamidzr hamidzr requested a review from a team as a code owner March 29, 2024 17:41
@hamidzr hamidzr requested a review from ioga March 29, 2024 17:41
@cla-bot cla-bot bot added the cla-signed label Mar 29, 2024
@hamidzr hamidzr changed the title oss: agent level check if slotstats are computed at rm level chore: agent level check if slotstats are computed at rm level Mar 29, 2024
Copy link

netlify bot commented Mar 29, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 86c70c5
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6606fde14f7156000890f05d

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.80%. Comparing base (1a38f0c) to head (c7b549a).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9073      +/-   ##
==========================================
- Coverage   47.06%   40.80%   -6.26%     
==========================================
  Files        1154      987     -167     
  Lines      142372   129941   -12431     
  Branches     2423     2421       -2     
==========================================
- Hits        67005    53027   -13978     
- Misses      75177    76724    +1547     
  Partials      190      190              
Flag Coverage Δ
harness 41.66% <ø> (-22.41%) ⬇️
web 38.95% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/api_agents.go 0.00% <ø> (ø)

... and 255 files with indirect coverage changes

@hamidzr hamidzr enabled auto-merge (squash) March 29, 2024 17:45
@hamidzr hamidzr merged commit 5031807 into main Mar 29, 2024
67 of 81 checks passed
@hamidzr hamidzr deleted the hz-agentslots-safetycheck branch March 29, 2024 18:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants