Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix TestScheduleRetention #9069

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: fix TestScheduleRetention #9069

merged 1 commit into from
Mar 28, 2024

Conversation

salonig23
Copy link
Contributor

@salonig23 salonig23 commented Mar 28, 2024

Description

Test-go was failing on main because of TestScheduleRetention. Split it into 3 parts to avoid timing out

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 28, 2024
Copy link

netlify bot commented Mar 28, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit c8c3214
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6605b76f8510dd0009614fee
😎 Deploy Preview https://deploy-preview-9069--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.17%. Comparing base (85bb3c8) to head (c8c3214).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9069      +/-   ##
==========================================
- Coverage   47.18%   47.17%   -0.01%     
==========================================
  Files        1152     1152              
  Lines      141773   141773              
  Branches     2417     2417              
==========================================
- Hits        66890    66885       -5     
- Misses      74693    74698       +5     
  Partials      190      190              
Flag Coverage Δ
backend 43.00% <ø> (-0.02%) ⬇️
harness 64.31% <ø> (ø)
web 38.96% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@salonig23 salonig23 marked this pull request as ready for review March 28, 2024 18:39
@salonig23 salonig23 requested a review from a team as a code owner March 28, 2024 18:39
@salonig23 salonig23 requested a review from jgongd March 28, 2024 18:39
@salonig23 salonig23 merged commit 53bf20e into main Mar 28, 2024
73 of 85 checks passed
@salonig23 salonig23 deleted the fix-log-retention-test branch March 28, 2024 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants