-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: spacing issue with exp list pagination #9067
Conversation
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9067 +/- ##
==========================================
- Coverage 47.18% 40.63% -6.55%
==========================================
Files 1152 831 -321
Lines 141773 102581 -39192
Branches 2417 2417
==========================================
- Hits 66890 41685 -25205
+ Misses 74693 60706 -13987
Partials 190 190
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does the gap not work if you wrap pagination in a row? having a spacer element seems yucky.
gap for row only works if there are multiple child elements, realized it makes more sense to have the gap applied to the wrapper |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description
Minor follow up to #8956. Adding back spacing between Pagination component and DataGrid when infinite scroll is off.
Test Plan
Follow up to refactor PR, should not require additional testing for release.
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket