Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Remove /lore redirect from deployment template #9057

Merged
merged 1 commit into from
Mar 27, 2024

Conversation

szewaiyuen6
Copy link
Contributor

@szewaiyuen6 szewaiyuen6 commented Mar 26, 2024

Description

A follow-up PR to: #8492

Removing the outdated /lore redirect (replaced by /gen redirect in the previous pr). It was kept around as GenAI CI wasn't caught up.

Test Plan

(1) Tested that the cluster can be launched with the change
Screen Shot 2024-03-27 at 12 22 30 PM

(2) tested that the master.yaml indeed contains the update (only /genai redirect is seen)
Screen Shot 2024-03-27 at 12 22 47 PM

(3) tested that /genai redirect still works

Screen Shot 2024-03-27 at 11 56 43 AM

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@szewaiyuen6 szewaiyuen6 requested a review from a team as a code owner March 26, 2024 23:38
@cla-bot cla-bot bot added the cla-signed label Mar 26, 2024
Copy link

netlify bot commented Mar 26, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 65d4747
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/66035d1b38cc150008d8923d

Copy link

codecov bot commented Mar 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.79%. Comparing base (1e6f0f7) to head (65d4747).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9057      +/-   ##
==========================================
- Coverage   49.49%   47.79%   -1.71%     
==========================================
  Files         752     1166     +414     
  Lines      103789   143619   +39830     
  Branches     2386     2386              
==========================================
+ Hits        51374    68646   +17272     
- Misses      52256    74814   +22558     
  Partials      159      159              
Flag Coverage Δ
backend 42.83% <ø> (+8.58%) ⬆️
harness 64.34% <ø> (ø)
web 40.75% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 414 files with indirect coverage changes

@szewaiyuen6 szewaiyuen6 marked this pull request as draft March 26, 2024 23:41
@szewaiyuen6 szewaiyuen6 marked this pull request as ready for review March 27, 2024 19:28
Copy link
Contributor

@tayritenour tayritenour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wes-turner wes-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@szewaiyuen6 szewaiyuen6 merged commit 06c86ee into main Mar 27, 2024
71 of 83 checks passed
@szewaiyuen6 szewaiyuen6 deleted the remove_lore_redirect branch March 27, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants