Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: change profiler docs url #9034

Closed
wants to merge 1 commit into from

Conversation

keita-determined
Copy link
Contributor

@keita-determined keita-determined commented Mar 21, 2024

Description

Request from @tara-det-ai
The original docs change PR: #9011, and #9032
WEB-2004

Test Plan

  • Go to profiler tab in experiment detail page that doesn't show profiler
  • Click the doc link
  • Check if the link goes to /model-dev-guide/profiling.html

Commentary (optional)

  • The link is not publicly published yet, so not see the link in latest-main website

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 21, 2024
Copy link

codecov bot commented Mar 21, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 41.73%. Comparing base (e4bc377) to head (7dd2578).
Report is 17 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9034      +/-   ##
==========================================
- Coverage   47.80%   41.73%   -6.08%     
==========================================
  Files        1161      841     -320     
  Lines      143646   104178   -39468     
  Branches     2373     2373              
==========================================
- Hits        68673    43475   -25198     
+ Misses      74820    60550   -14270     
  Partials      153      153              
Flag Coverage Δ
harness ?
web 40.90% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...ct/src/pages/TrialDetails/TrialDetailsProfiles.tsx 48.83% <0.00%> (+2.17%) ⬆️

... and 320 files with indirect coverage changes

@keita-determined keita-determined force-pushed the fix/change-profile-docs-url branch from 1f08a3c to 7dd2578 Compare March 21, 2024 19:37
Copy link

netlify bot commented Mar 21, 2024

Deploy Preview for determined-ui ready!

Name Link
🔨 Latest commit 7dd2578
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65fc8c934fd0820008ac4cba
😎 Deploy Preview https://deploy-preview-9034--determined-ui.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@keita-determined keita-determined marked this pull request as ready for review March 21, 2024 19:38
@keita-determined keita-determined requested a review from a team as a code owner March 21, 2024 19:38
@keita-determined keita-determined requested a review from gt2345 March 21, 2024 19:38
@keita-determined keita-determined changed the title fix: change profile docs url fix: change profiler docs url Mar 21, 2024
Copy link
Contributor

@gt2345 gt2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good to me, but I think it maybe better to land this after the docs change lands.

Copy link
Contributor

@tara-hpe tara-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@keita-determined keita-determined added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 27, 2024
@mackrorysd mackrorysd self-assigned this Mar 27, 2024
@keita-determined
Copy link
Contributor Author

close this pr because profiler page doesnt require doc link

@keita-determined keita-determined deleted the fix/change-profile-docs-url branch March 27, 2024 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants