Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: test-perf uses determined version from github #9019

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

wes-turner
Copy link
Contributor

Instead of installing determined from PyPI with pip, test-perf now pulls its determined from GitHub. This is to make it possible to coordinate changes between the python files that run as a part of the test and the libraries within determined that those files call.

Description

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

Instead of installing determined from PyPI with pip, test-perf now pulls
its determined from GitHub. This is to make it possible to coordinate
changes between the python files that run as a part of the test and the
libraries within determined that those files call.
@cla-bot cla-bot bot added the cla-signed label Mar 18, 2024
Copy link

netlify bot commented Mar 18, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit ca70263
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f8d10766cbc300082b5783

Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.72%. Comparing base (8bf280d) to head (ca70263).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9019      +/-   ##
==========================================
- Coverage   47.72%   47.72%   -0.01%     
==========================================
  Files        1160     1160              
  Lines      142916   142916              
  Branches     2372     2372              
==========================================
- Hits        68207    68202       -5     
- Misses      74556    74561       +5     
  Partials      153      153              
Flag Coverage Δ
backend 42.58% <ø> (-0.02%) ⬇️
harness 63.98% <ø> (ø)
web 40.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

@wes-turner wes-turner requested review from dannysauer and NicholasBlaskey and removed request for dannysauer March 19, 2024 00:01
@wes-turner wes-turner marked this pull request as ready for review March 19, 2024 00:03
@wes-turner wes-turner requested a review from a team as a code owner March 19, 2024 00:03
@wes-turner wes-turner merged commit fa43bff into main Mar 19, 2024
74 of 85 checks passed
@wes-turner wes-turner deleted the wes/test-perf-from-github branch March 19, 2024 15:56
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Instead of installing determined from PyPI with pip, test-perf now pulls
its determined from GitHub. This is to make it possible to coordinate
changes between the python files that run as a part of the test and the
libraries within determined that those files call.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants