-
Notifications
You must be signed in to change notification settings - Fork 364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: helm for multirm kubeconfig_path #9015
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #9015 +/- ##
==========================================
- Coverage 47.63% 47.63% -0.01%
==========================================
Files 1159 1159
Lines 142794 142794
Branches 2338 2337 -1
==========================================
- Hits 68024 68019 -5
- Misses 74617 74622 +5
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing a values.yaml example? or are you going to put that in a separate PR?
I don't want to add things to values.yaml before they are released since it is a public file people are going to be using. |
missing a
This is going to be included in the next release, afaik this change is the last we're waiting on? |
I can add it in a seperate PR after we create the example tutorial/setup docs. |
Description
Adds helm changes for kubeconfig for multirm.
Test Plan
Deploy kube
Get context for a gke cluster
Deploy secrets
Edit
values.yaml
Deploy (master version shouldn't matter as long as relatively recent)
Master should fail with
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket