Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Update Deploy on GCP #8985

Merged
merged 2 commits into from
Mar 12, 2024
Merged

docs: Update Deploy on GCP #8985

merged 2 commits into from
Mar 12, 2024

Conversation

tara-det-ai
Copy link
Contributor

Description

Community request: clarify that the instructions for Deploying on GCP are not used to spin up a cluster via GKE.

@cla-bot cla-bot bot added the cla-signed label Mar 11, 2024
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Mar 11, 2024
@determined-ci determined-ci requested a review from a team March 11, 2024 17:58
Copy link

netlify bot commented Mar 11, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit f4b8220
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65f09e9267d4820008a48416

use Kubernetes, please refer to :ref:`setup-gke-cluster`.

Determined uses Google Compute Engine (GCE) instances as its base unit. The cluster is managed by a
`master` node (a single, non-GPU instance), which in turn provisions and deprovisions other `agent`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
`master` node (a single, non-GPU instance), which in turn provisions and deprovisions other `agent`
*master* node (a single non-GPU instance), which in turn provisions and deprovisions other *agent*

Comment on lines 19 to 20
For instance, if only a `master` node is running, charges are incurred solely for the master. When
an experiment starts, the master dynamically provisions GPU instances as `agents`. Once the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
For instance, if only a `master` node is running, charges are incurred solely for the master. When
an experiment starts, the master dynamically provisions GPU instances as `agents`. Once the
For instance, if only a master node is running, charges are incurred solely for the master. When
an experiment starts, the master dynamically provisions GPU instances as agents. Once the

per Community request, clarify that the instructions for Deploying on GCP are not used to spin up a cluster via GKE.
@determined-ci determined-ci requested a review from a team March 12, 2024 17:48
@tara-det-ai tara-det-ai enabled auto-merge (squash) March 12, 2024 18:28
@tara-det-ai tara-det-ai merged commit 055dd83 into main Mar 12, 2024
65 of 78 checks passed
@tara-det-ai tara-det-ai deleted the docs/Update-Deploy-on-GCP branch March 12, 2024 18:34
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
* docs: Update Deploy on GCP

per Community request, clarify that the instructions for Deploying on GCP are not used to spin up a cluster via GKE.

* resolve review comments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants