-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update Deploy on GCP #8985
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
tara-det-ai
force-pushed
the
docs/Update-Deploy-on-GCP
branch
from
March 11, 2024 18:04
72a7ef0
to
dde8fc7
Compare
MikhailKardash
approved these changes
Mar 12, 2024
dzhu
approved these changes
Mar 12, 2024
docs/setup-cluster/gcp/_index.rst
Outdated
use Kubernetes, please refer to :ref:`setup-gke-cluster`. | ||
|
||
Determined uses Google Compute Engine (GCE) instances as its base unit. The cluster is managed by a | ||
`master` node (a single, non-GPU instance), which in turn provisions and deprovisions other `agent` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
`master` node (a single, non-GPU instance), which in turn provisions and deprovisions other `agent` | |
*master* node (a single non-GPU instance), which in turn provisions and deprovisions other *agent* |
docs/setup-cluster/gcp/_index.rst
Outdated
Comment on lines
19
to
20
For instance, if only a `master` node is running, charges are incurred solely for the master. When | ||
an experiment starts, the master dynamically provisions GPU instances as `agents`. Once the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
For instance, if only a `master` node is running, charges are incurred solely for the master. When | |
an experiment starts, the master dynamically provisions GPU instances as `agents`. Once the | |
For instance, if only a master node is running, charges are incurred solely for the master. When | |
an experiment starts, the master dynamically provisions GPU instances as agents. Once the |
per Community request, clarify that the instructions for Deploying on GCP are not used to spin up a cluster via GKE.
tara-det-ai
force-pushed
the
docs/Update-Deploy-on-GCP
branch
from
March 12, 2024 17:48
dde8fc7
to
5853395
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
* docs: Update Deploy on GCP per Community request, clarify that the instructions for Deploying on GCP are not used to spin up a cluster via GKE. * resolve review comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Community request: clarify that the instructions for Deploying on GCP are not used to spin up a cluster via GKE.