-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add new endpoints to change log retention for exps and trials [DET-9995] #8982
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8982 +/- ##
==========================================
- Coverage 52.04% 47.12% -4.93%
==========================================
Files 750 1153 +403
Lines 80799 142358 +61559
Branches 0 2421 +2421
==========================================
+ Hits 42053 67082 +25029
- Misses 38746 75086 +36340
- Partials 0 190 +190
Flags with carried forward coverage won't be shown. Click here to find out more.
|
dc39481
to
116930a
Compare
stoksc
reviewed
Mar 11, 2024
stoksc
reviewed
Mar 11, 2024
stoksc
reviewed
Mar 11, 2024
stoksc
reviewed
Mar 11, 2024
6d62447
to
0d358a3
Compare
webui/react/src/pages/ExperimentDetails/ExperimentDetailsHeader.tsx
Outdated
Show resolved
Hide resolved
d4feacb
to
1c5a684
Compare
6451894
to
6cf216e
Compare
65d75e3
to
6f9c861
Compare
76f85f0
to
3524b9a
Compare
ad0d3cc
to
af20a5c
Compare
849c354
to
2f0bc0e
Compare
af20a5c
to
da7f1dc
Compare
53fc2e9
to
e4b392b
Compare
da7f1dc
to
89c07fb
Compare
e4b392b
to
a8d651b
Compare
a8d651b
to
89c07fb
Compare
89c07fb
to
ee1e140
Compare
e558e6d
to
9c61551
Compare
9c61551
to
c8ffa61
Compare
✅ Deploy Preview for determined-ui ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
c8ffa61
to
c2f5e39
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added new API Endpoints, CLI commands and WebUI elements to change log retention for experiments and trials
Test Plan
For CLI -
Experiment:
det e set log-retention-days <exp-id> --days 50
det e set log-retention-days <exp-id> --days none --forever
Trial:
det t set log-retention-days <trial-id> --days 50
for any trial in the experiment.det t set log-retention-days <trial-id> --days none --forever
For API -
Check the tasks table in the database to see if the associated tasks for the experiment have updated the log retention days to 40.
Check the tasks table in the database to see if the associated tasks for the trial have updated the log retention days to -1.
For WebUI -
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket
DET-9995