chore: multirm unique resource pool config changes [RM-74] #8974
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8974 +/- ##
==========================================
- Coverage 47.47% 47.47% -0.01%
==========================================
Files 1168 1168
Lines 176294 176297 +3
Branches 2352 2350 -2
==========================================
+ Hits 83701 83702 +1
- Misses 92435 92437 +2
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
carolinaecalderon
approved these changes
Mar 8, 2024
| @@ -87,45 +87,51 @@ func (r *ResourceConfig) ResolveResource() error { | |||
| r.RootManagerInternal.setName(DefaultRMName) | |||
| } | |||
|
|
|||
| // Add a default resource pool for all non resource managers. | |||
| // Add a default resource pool for nonslurm default resource managers. | |||
There was a problem hiding this comment.
note: maybe add a TODO (multirm slurm) note here, just as a reminder to bradley/whoever works on this project next?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Require unique resource pool names in config.
Test Plan
unit tests
Commentary (optional)
Checklist
docs/release-notes/.See Release Note for details.
Ticket