Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: set CGO_ENABLED=0 #8941

Merged
merged 3 commits into from
Mar 5, 2024
Merged

chore: set CGO_ENABLED=0 #8941

merged 3 commits into from
Mar 5, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Mar 4, 2024

Description

Set CGO_ENABLED=0 when building Determined so we don't need to depend on GLIBC.

https://hpe-aiatscale.slack.com/archives/C058AC320M9/p1709568451569729

Test Plan

Full e2e suite passes

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Mar 4, 2024
Copy link

netlify bot commented Mar 4, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 36a40d0
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e60166009c3c000816c5d7

Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.21%. Comparing base (0d61d15) to head (36a40d0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8941      +/-   ##
==========================================
- Coverage   47.22%   47.21%   -0.01%     
==========================================
  Files        1162     1162              
  Lines      175913   175913              
  Branches     2237     2237              
==========================================
- Hits        83067    83061       -6     
- Misses      92688    92694       +6     
  Partials      158      158              
Flag Coverage Δ
backend 42.07% <ø> (-0.02%) ⬇️
harness 63.93% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review March 4, 2024 19:58
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner March 4, 2024 19:58
Copy link
Contributor

@stoksc stoksc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanna turn it on for all builds? (even build-race)

@stoksc stoksc assigned NicholasBlaskey and unassigned stoksc Mar 4, 2024
@NicholasBlaskey
Copy link
Contributor Author

wanna turn it on for all builds? (even build-race)

go: -race requires cgo; enable cgo by setting CGO_ENABLED=1

is kinda annoying that our tests in CI, which use the race detector, will need CGO but builds won't use it

@stoksc
Copy link
Contributor

stoksc commented Mar 4, 2024

ah yeah, duh. --race actually uses tsan or something, right? i forgot.

@NicholasBlaskey NicholasBlaskey merged commit e108ed7 into main Mar 5, 2024
99 of 101 checks passed
@NicholasBlaskey NicholasBlaskey deleted the try_cgo_enabled_false branch March 5, 2024 16:49
maxrussell pushed a commit that referenced this pull request Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants