-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: set CGO_ENABLED=0 #8941
chore: set CGO_ENABLED=0 #8941
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8941 +/- ##
==========================================
- Coverage 47.22% 47.21% -0.01%
==========================================
Files 1162 1162
Lines 175913 175913
Branches 2237 2237
==========================================
- Hits 83067 83061 -6
- Misses 92688 92694 +6
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
1275727
to
36a40d0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wanna turn it on for all builds? (even build-race)
is kinda annoying that our tests in CI, which use the race detector, will need CGO but builds won't use it |
ah yeah, duh. --race actually uses tsan or something, right? i forgot. |
Description
Set
CGO_ENABLED=0
when building Determined so we don't need to depend on GLIBC.https://hpe-aiatscale.slack.com/archives/C058AC320M9/p1709568451569729
Test Plan
Full e2e suite passes
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket