-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: malformed config with gcp up with --initial-user-password #8936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
@ioga put you on this since you have some running context on this change. |
stoksc
added
the
to-cherry-pick
Pull requests that need to be cherry-picked into the current release
label
Mar 1, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #8936 +/- ##
=======================================
Coverage 47.19% 47.19%
=======================================
Files 1155 1155
Lines 175114 175114
Branches 2237 2237
=======================================
+ Hits 82645 82647 +2
+ Misses 92311 92309 -2
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more. |
ioga
approved these changes
Mar 2, 2024
landing this over ci since this doesn't run in ci at all |
dai-release bot
pushed a commit
that referenced
this pull request
Mar 4, 2024
(cherry picked from commit f997cd8)
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I moved this as a style thing last minute before landing this change and missed that we
>>
into the master.yml.context in a way that breaks this. Also the yaml indentation ended up wrong.Test Plan
det deploy gcp up --initial-user-password ...
local and ensure password login works as expectedCommentary (optional)
oops
Checklist
docs/release-notes/
.See Release Note for details.
Ticket