Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: malformed config with gcp up with --initial-user-password #8936

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Mar 1, 2024

Description

I moved this as a style thing last minute before landing this change and missed that we >> into the master.yml.context in a way that breaks this. Also the yaml indentation ended up wrong.

Test Plan

  • run det deploy gcp up --initial-user-password ... local and ensure password login works as expected

Commentary (optional)

oops

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@stoksc stoksc requested a review from a team as a code owner March 1, 2024 22:32
@stoksc stoksc requested a review from szewaiyuen6 March 1, 2024 22:32
@cla-bot cla-bot bot added the cla-signed label Mar 1, 2024
@stoksc stoksc requested review from ioga and removed request for szewaiyuen6 March 1, 2024 22:32
Copy link

netlify bot commented Mar 1, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 580eeb9
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65e2577b620886000810e414

@stoksc
Copy link
Contributor Author

stoksc commented Mar 1, 2024

@ioga put you on this since you have some running context on this change.

@stoksc stoksc added the to-cherry-pick Pull requests that need to be cherry-picked into the current release label Mar 1, 2024
Copy link

codecov bot commented Mar 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.19%. Comparing base (2dfc4f2) to head (580eeb9).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8936   +/-   ##
=======================================
  Coverage   47.19%   47.19%           
=======================================
  Files        1155     1155           
  Lines      175114   175114           
  Branches     2237     2237           
=======================================
+ Hits        82645    82647    +2     
+ Misses      92311    92309    -2     
  Partials      158      158           
Flag Coverage Δ
backend 42.37% <ø> (+<0.01%) ⬆️
harness 63.71% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

@stoksc stoksc enabled auto-merge (squash) March 1, 2024 22:33
@stoksc stoksc disabled auto-merge March 4, 2024 16:26
@stoksc
Copy link
Contributor Author

stoksc commented Mar 4, 2024

landing this over ci since this doesn't run in ci at all

@stoksc stoksc merged commit f997cd8 into main Mar 4, 2024
52 of 88 checks passed
@stoksc stoksc deleted the fix-gcp-initial-password branch March 4, 2024 16:27
dai-release bot pushed a commit that referenced this pull request Mar 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed to-cherry-pick Pull requests that need to be cherry-picked into the current release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants