Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add template to py sdk create_experiment #8927

Merged
merged 19 commits into from
Mar 20, 2024

Conversation

gt2345
Copy link
Contributor

@gt2345 gt2345 commented Feb 29, 2024

Description

Allow python sdk create_experiment function to take parameters parent_id, project_id and template

Test Plan

Use python sdk to create an experiment with parent_id, project_id and template

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@gt2345 gt2345 requested a review from a team as a code owner February 29, 2024 17:37
@cla-bot cla-bot bot added the cla-signed label Feb 29, 2024
Copy link

netlify bot commented Feb 29, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit d356346
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65fb206c20fa4800083cb4c9

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 47.82%. Comparing base (39afa3c) to head (d356346).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8927      +/-   ##
==========================================
- Coverage   47.82%   47.82%   -0.01%     
==========================================
  Files        1161     1161              
  Lines      143486   143486              
  Branches     2372     2372              
==========================================
- Hits        68621    68620       -1     
- Misses      74712    74713       +1     
  Partials      153      153              
Flag Coverage Δ
backend 43.04% <ø> (-0.01%) ⬇️
harness 63.84% <0.00%> (ø)
web 40.86% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...rness/determined/common/experimental/determined.py 41.21% <ø> (ø)
harness/determined/experimental/client.py 55.26% <0.00%> (ø)

... and 4 files with indirect coverage changes

@gt2345 gt2345 force-pushed the gt/254-create-exp-w-template branch from dd6ae4c to 8f171d6 Compare February 29, 2024 17:45
@gt2345 gt2345 requested a review from ioga February 29, 2024 18:14
@gt2345 gt2345 requested a review from wes-turner March 4, 2024 20:26
@gt2345 gt2345 requested a review from wes-turner March 12, 2024 21:14
@wes-turner wes-turner assigned wes-turner and gt2345 and unassigned wes-turner Mar 14, 2024
@gt2345 gt2345 requested a review from wes-turner March 15, 2024 15:52
@gt2345 gt2345 requested a review from a team as a code owner March 19, 2024 21:15
Copy link
Contributor

@wes-turner wes-turner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@gt2345 gt2345 merged commit 4441d6d into main Mar 20, 2024
68 of 81 checks passed
@gt2345 gt2345 deleted the gt/254-create-exp-w-template branch March 20, 2024 20:56
wes-turner pushed a commit that referenced this pull request Mar 28, 2024
Follow up for #8927
Since parent id is mostly used internally, and can be confusing for end user when exposed, we decide to remove it from SDK function create_experiment
dai-release bot pushed a commit that referenced this pull request Mar 28, 2024
Follow up for #8927
Since parent id is mostly used internally, and can be confusing for end user when exposed, we decide to remove it from SDK function create_experiment

(cherry picked from commit 1e45918)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants