-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add template to py sdk create_experiment
#8927
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8927 +/- ##
==========================================
- Coverage 47.82% 47.82% -0.01%
==========================================
Files 1161 1161
Lines 143486 143486
Branches 2372 2372
==========================================
- Hits 68621 68620 -1
- Misses 74712 74713 +1
Partials 153 153
Flags with carried forward coverage won't be shown. Click here to find out more.
|
gt2345
force-pushed
the
gt/254-create-exp-w-template
branch
from
February 29, 2024 17:45
dd6ae4c
to
8f171d6
Compare
wes-turner
reviewed
Feb 29, 2024
wes-turner
reviewed
Mar 7, 2024
wes-turner
reviewed
Mar 7, 2024
wes-turner
reviewed
Mar 7, 2024
wes-turner
reviewed
Mar 7, 2024
wes-turner
reviewed
Mar 7, 2024
wes-turner
reviewed
Mar 14, 2024
wes-turner
reviewed
Mar 14, 2024
wes-turner
approved these changes
Mar 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
4 tasks
wes-turner
pushed a commit
that referenced
this pull request
Mar 28, 2024
Follow up for #8927 Since parent id is mostly used internally, and can be confusing for end user when exposed, we decide to remove it from SDK function create_experiment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow python sdk
create_experiment
function to take parametersparent_id
,project_id
andtemplate
Test Plan
Use python sdk to create an experiment with parent_id, project_id and template
Commentary (optional)
Checklist
docs/release-notes/
.See Release Note for details.
Ticket