Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: revert pod spec and test changes #8920

Merged
merged 1 commit into from
Feb 29, 2024

Conversation

NicholasBlaskey
Copy link
Contributor

@NicholasBlaskey NicholasBlaskey commented Feb 28, 2024

Description

Reverts #8899 due to a security issue.

Test Plan

Commentary (optional)

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

@cla-bot cla-bot bot added the cla-signed label Feb 28, 2024
Copy link

netlify bot commented Feb 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 437bb30
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65df9f5d6365c400072adcc8

Copy link

codecov bot commented Feb 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 47.16%. Comparing base (ef49195) to head (437bb30).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #8920   +/-   ##
=======================================
  Coverage   47.16%   47.16%           
=======================================
  Files        1154     1154           
  Lines      175071   175070    -1     
  Branches     2237     2237           
=======================================
+ Hits        82575    82580    +5     
+ Misses      92338    92332    -6     
  Partials      158      158           
Flag Coverage Δ
backend 42.27% <ø> (+0.01%) ⬆️
harness 63.69% <ø> (ø)
web 42.53% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
master/internal/rm/kubernetesrm/spec.go 71.62% <ø> (-0.08%) ⬇️

... and 5 files with indirect coverage changes

@NicholasBlaskey NicholasBlaskey marked this pull request as ready for review February 28, 2024 21:17
@NicholasBlaskey NicholasBlaskey requested a review from a team as a code owner February 28, 2024 21:17
@NicholasBlaskey NicholasBlaskey merged commit cd88bb5 into main Feb 29, 2024
82 of 92 checks passed
@NicholasBlaskey NicholasBlaskey deleted the pod_spec_revert_changes branch February 29, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants