chore: minor tweaks as modev takes over streaming updates #8909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rb-determined-ai
commented
Feb 27, 2024
rb-determined-ai
commented
- add DESIGN doc back into code
- fix some typos in comments
- rely on defer in the context cancelation function
- eliminate unnecessary/unhelpful wrapper function
- use time.Ticker instead of time.After
rb-determined-ai
requested review from
jgongd
and removed request for
salonig23
✅ Deploy Preview for determined-ui canceled.
|
jgongd
approved these changes
Feb 27, 2024
rb-determined-ai
force-pushed
the
rb/streaming-updates-tweaks
branch
from
28ddf78
to
9492bfb
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8909 +/- ##
==========================================
+ Coverage 44.44% 47.53% +3.09%
==========================================
Files 1038 1066 +28
Lines 168477 170228 +1751
Branches 2235 2236 +1
==========================================
+ Hits 74873 80915 +6042
+ Misses 93446 89155 -4291
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
- add DESIGN doc back into code - fix some typos in comments - rely on defer in the context cancelation function - eliminate unnecessary/unhelpful wrapper function - use time.Ticker instead of time.After
rb-determined-ai
force-pushed
the
rb/streaming-updates-tweaks
branch
from
9492bfb
to
0f7be7a
Compare
maxrussell
pushed a commit
that referenced
this pull request
Mar 21, 2024
- add DESIGN doc back into code - fix some typos in comments - rely on defer in the context cancelation function - eliminate unnecessary/unhelpful wrapper function - use time.Ticker instead of time.After
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.