Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: ngc release notes and license #8823

Closed
wants to merge 3 commits into from
Closed

Conversation

MikhailKardash
Copy link
Contributor

@MikhailKardash MikhailKardash commented Feb 9, 2024

Description

Requirement for merging determined-ai/environments#235
Adds NGC container license and updates gen-attributions.py to account for NVIDIA container license types.
Also adds release note.

Test Plan

No testing required

Checklist

  • Changes have been manually QA'd
  • User-facing API changes need the "User-facing API Change" label.
  • Release notes should be added as a separate file under docs/release-notes/.
    See Release Note for details.
  • Licenses should be included for new code which was copied and/or modified from any external code.

Ticket

MD-270

@cla-bot cla-bot bot added the cla-signed label Feb 9, 2024
Copy link

netlify bot commented Feb 9, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit 2574120
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/65ca9ba045195000086f0d56

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (43d3f21) 47.80% compared to head (2574120) 47.80%.
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #8823      +/-   ##
==========================================
- Coverage   47.80%   47.80%   -0.01%     
==========================================
  Files        1050     1050              
  Lines      167370   167370              
  Branches     2238     2238              
==========================================
- Hits        80014    80013       -1     
- Misses      87198    87199       +1     
  Partials      158      158              
Flag Coverage Δ
backend 43.69% <ø> (-0.01%) ⬇️
harness 64.32% <ø> (ø)
web 42.52% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 3 files with indirect coverage changes

@determined-ci determined-ci added the documentation Improvements or additions to documentation label Feb 9, 2024
@determined-ci determined-ci requested a review from a team February 9, 2024 21:30
@MikhailKardash MikhailKardash requested review from vishnu2kmohan and a team and removed request for a team February 9, 2024 21:30
**Improvements**

- Remove TF 2.8 images from our offerings. Our default TF 2.11 images are still available for
Tensorflow users.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New Features

  • Add experimental NGC-based images in our environments offerings. These images can be pulled from
    https://hub.docker.com/r/determinedai/pytorch-ngc or
    https://hub.docker.com/r/determinedai/tensorflow-ngc

Improvements

  • Remove TF 2.8 images from our offerings. Default TF 2.11 images are still available for TensorFlow users.

Copy link
Contributor

@tara-det-ai tara-det-ai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggested edit

@determined-ci determined-ci requested a review from a team February 12, 2024 22:28
@MikhailKardash MikhailKardash deleted the ngc_license branch March 25, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants