feat: streaming updates python client [MD-246] #8778
Conversation
rb-determined-ai
requested review from
tayritenour and
maxrussell
and removed request for
a team
rb-determined-ai
requested review from
corban-beaird
and removed request for
maxrussell
corban-beaird
force-pushed
the
corban-beaird-streaming-updates-core-func
branch
from
80dc1ee to
1c35290
Compare
rb-determined-ai
force-pushed
the
rb/streaming-updates-client
branch
from
a0b958c to
87bd990
Compare
✅ Deploy Preview for determined-ui canceled.
|
rb-determined-ai
force-pushed
the
rb/streaming-updates-client
branch
from
87bd990 to
e3c6e26
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #8778 +/- ##
==========================================
+ Coverage 47.19% 47.21% +0.02%
==========================================
Files 1155 1162 +7
Lines 175115 175914 +799
Branches 2237 2237
==========================================
+ Hits 82648 83064 +416
- Misses 92309 92692 +383
Partials 158 158
Flags with carried forward coverage won't be shown. Click here to find out more.
|
rb-determined-ai
force-pushed
the
rb/streaming-updates-client
branch
from
e3c6e26 to
6e82c5e
Compare
rb-determined-ai
force-pushed
the
rb/streaming-updates-client
branch
3 times, most recently
from
cde2786 to
3d45715
Compare
master/cmd/stream-gen/main.go
Outdated
| overwritten if it would be modified. | ||
|
|
||
| If --stamp is provided, the STAMP file will be touched after a successful run, which is useful for | ||
| integration with build systems. |
There was a problem hiding this comment.
I'm curious how the stamp file is used for integration with build systems. Is there an example in the code base that I can take a look at?
There was a problem hiding this comment.
you know, looking at this... there isn't a good reason for a --stamp output with how this function behaves. I'll just remove this.
rb-determined-ai
force-pushed
the
rb/streaming-updates-client
branch
from
3d45715 to
5af6e2b
Compare
|
I need to figure out the CI situation here before landing this. The code generation may complicate the relationships between stages. Ugh. |
This includes a new code generator. Our existing code generation is proto -> openapi -> tweaks -> python, with an alternate proto -> go path for the server code. This is more direct, it's go -> python; the go code is the source of truth and we can write the generator in go to use go's ast package.
no... that's not right. CI is fine. Since we still commit generated code, the I will include |
rb-determined-ai
force-pushed
the
rb/streaming-updates-client
branch
from
5af6e2b to
045e508
Compare
rb-determined-ai
changed the title
This includes a new code generator. Our existing code generation is proto -> openapi -> tweaks -> python, with an alternate proto -> go path for the server code. This is more direct, it's go -> python; the go code is the source of truth and we can write the generator in go to use go's ast package.
This includes a new code generator.
Our existing code generation is proto -> openapi -> tweaks -> python, with an alternate proto -> go path for the server code.
This is more direct, it's go -> python; the go code is the source of truth and we can write the generator in go to use go's ast package.
Test Plan
Feature is not yet user-facing. Automated testing is sufficient.
Commentary
I configured the PR against the streaming updates "core functionality" feature branch lands for reviewability, but I plan on landing it to main after that branch lands.