chore: Use nullable types in PatchExperiment [DET-6486]

[mapmeld]

Description

Replace the field masking / multiple queries format of PATCH /api/v1/experiment/:id and instead, following the Models API, accept a PatchExperiment body with nullable types. This allows us to send a partial update { "id": 101, "name": "new_name" } and the other fields will be unchanged.

Checklist

• User-facing API changes need the "User-facing API Change" label.
• Release notes should be added as a separate file under docs/release-notes/.
• Licenses should be included for new code which was copied and/or modified from any external code.

[netlify]

✔️ Deploy Preview for determined-ui ready!

🔨 Explore the source changes: abb5727

🔍 Inspect the deploy log: https://app.netlify.com/sites/determined-ui/deploys/61f9782c12ebae00097fe8ea

😎 Browse the preview: https://deploy-preview-3497--determined-ui.netlify.app/

[hamidzr]

the approach lgtm. I'll check it out more and get back to you in a bit

[hamidzr]

👍🏼

[hamidzr]

already we get some validation which is great. It'd be great if it also prevented users from sending unacceptable patches and not accepting inaccurate values:

could we respond with some sort of error like it used to?

[mapmeld]

Proto (as of v3) drops any unknown fields before passing it to our Go code ( protocolbuffers/protobuf#272 , golang/protobuf#1390 ). The best way that someone can know that their unexpected change didn't happen, at the moment, is to look at the Experiment which we returned and that the field isn't added or updated.

[mapmeld]

oh I should look into this https://developers.google.com/protocol-buffers/docs/proto3#unknowns

in version 3.5 we reintroduced the preservation of unknown fields to match the proto2 behavior. In versions 3.5 and later, unknown fields are retained during parsing and included in the serialized output

[hamidzr]

aah 34

oh I should look into this https://developers.google.com/protocol-buffers/docs/proto3#unknowns

in version 3.5 we reintroduced the preservation of unknown fields to match the proto2 behavior. In versions 3.5 and later, unknown fields are retained during parsing and included in the serialized output

is that how fieldmask retained unknown paths? last image here #3497 (review)
?

looks like all the generated structs in go have an unknownFileds attached to them but that's internal