Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make some k8s tests pass #10224

Merged
merged 2 commits into from
Nov 21, 2024
Merged

fix: make some k8s tests pass #10224

merged 2 commits into from
Nov 21, 2024

Conversation

maxrussell
Copy link
Contributor

@maxrussell maxrussell commented Nov 20, 2024

Description

Some tests weren't passing but I didn't wanna block cutting the RC or manual testing. This should fix the k8s tests that weren't passing.

Test Plan

None; automated test changes only

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit bdaa436
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/673f56851538f70007decd4b

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.69%. Comparing base (d644094) to head (bdaa436).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10224      +/-   ##
==========================================
- Coverage   57.63%   53.69%   -3.95%     
==========================================
  Files         751     1255     +504     
  Lines      103234   155754   +52520     
  Branches     3616     3617       +1     
==========================================
+ Hits        59503    83633   +24130     
- Misses      43598    71988   +28390     
  Partials      133      133              
Flag Coverage Δ
backend 45.87% <ø> (+2.06%) ⬆️
harness 67.37% <ø> (ø)
web 54.45% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 504 files with indirect coverage changes

---- 🚨 Try these New Features:

@stoksc stoksc merged commit b66ea84 into main Nov 21, 2024
69 of 87 checks passed
@stoksc stoksc deleted the max/fix-k8s-tests branch November 21, 2024 16:16
github-actions bot pushed a commit that referenced this pull request Nov 21, 2024
Co-authored-by: Bradley Laney <[email protected]>
(cherry picked from commit b66ea84)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants