Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix license check #10211

Merged
merged 3 commits into from
Nov 19, 2024
Merged

chore: fix license check #10211

merged 3 commits into from
Nov 19, 2024

Conversation

stoksc
Copy link
Contributor

@stoksc stoksc commented Nov 19, 2024

Ticket

Description

Test Plan

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@stoksc stoksc marked this pull request as ready for review November 19, 2024 21:39
@cla-bot cla-bot bot added the cla-signed label Nov 19, 2024
@stoksc stoksc requested a review from a team as a code owner November 19, 2024 21:39
Copy link

netlify bot commented Nov 19, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit fa33d5d
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/673d09e2a362a60008d6d50c

Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.06%. Comparing base (e56dd5a) to head (fa33d5d).
Report is 5 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10211      +/-   ##
==========================================
- Coverage   54.34%   54.06%   -0.28%     
==========================================
  Files        1259      448     -811     
  Lines      157346    77333   -80013     
  Branches     3653     3653              
==========================================
- Hits        85514    41813   -43701     
+ Misses      71699    35387   -36312     
  Partials      133      133              
Flag Coverage Δ
harness ?
web 54.32% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 812 files with indirect coverage changes

---- 🚨 Try these New Features:

@stoksc
Copy link
Contributor Author

stoksc commented Nov 19, 2024

merging over stuff i know is ok

@stoksc stoksc merged commit b198238 into main Nov 19, 2024
66 of 86 checks passed
@stoksc stoksc deleted the fix-license-check branch November 19, 2024 22:51
github-actions bot pushed a commit that referenced this pull request Nov 19, 2024
(cherry picked from commit b198238)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants