Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove track-prs for release project #10170

Merged
merged 2 commits into from
Nov 4, 2024

Conversation

carolinaecalderon
Copy link
Contributor

@carolinaecalderon carolinaecalderon commented Oct 31, 2024

Ticket

Description

Remove the "wait-for-checks" step in the auto-backport workflow.
Remove references & functionality to track PRs for the release party process -- this should be part of the a greater discussion if we want to track tickets in Github or JIRA, and new scripts should be written accordingly.

Test Plan

n/a

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

@cla-bot cla-bot bot added the cla-signed label Oct 31, 2024
Copy link

netlify bot commented Oct 31, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit e962b2c
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/6728edf9a32c44000825c33e

Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.33%. Comparing base (f02872a) to head (e962b2c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10170      +/-   ##
==========================================
- Coverage   54.35%   54.33%   -0.03%     
==========================================
  Files        1259     1259              
  Lines      157337   157337              
  Branches     3645     3645              
==========================================
- Hits        85526    85490      -36     
- Misses      71678    71714      +36     
  Partials      133      133              
Flag Coverage Δ
backend 46.10% <ø> (-0.07%) ⬇️
harness 71.14% <ø> (ø)
web 54.30% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

@carolinaecalderon carolinaecalderon marked this pull request as ready for review October 31, 2024 21:13
@carolinaecalderon carolinaecalderon requested a review from a team as a code owner October 31, 2024 21:13
Copy link
Contributor

@davidfluck-hpe davidfluck-hpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good; I just had two nitpicky style/spacing things. I will point out, though, that track-pr does rely on some rph functionality that doesn't run anymore as part of release cutting, like creating the new Next release GitHub project and such. I did that manually this time, but that's part of the rph/Casper stuff that doesn't run anymore, so be aware of that.

.github/workflows/backport.yaml Outdated Show resolved Hide resolved
.github/workflows/track-prs-for-release.yml Outdated Show resolved Hide resolved
Copy link

cla-bot bot commented Nov 4, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jgongd on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@cla-bot cla-bot bot removed the cla-signed label Nov 4, 2024
@determined-ci determined-ci requested a review from a team November 4, 2024 15:20
@determined-ci determined-ci added the documentation Improvements or additions to documentation label Nov 4, 2024
Copy link

cla-bot bot commented Nov 4, 2024

Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have the users @jgongd on file. In order for us to review and merge your code, please start the CLA process at https://determined.ai/cla.

After we approve your CLA, we will update the contributors list (private) and comment @cla-bot[bot] check to rerun the check.

@cla-bot cla-bot bot added the cla-signed label Nov 4, 2024
@determined-ci determined-ci removed the documentation Improvements or additions to documentation label Nov 4, 2024
@carolinaecalderon carolinaecalderon changed the title chore: amend track-pr for new backport label chore: remove track-prs for release project Nov 4, 2024
@carolinaecalderon carolinaecalderon requested review from stoksc and a team and removed request for a team, EmilyBonar and azhou-determined November 4, 2024 15:55
@carolinaecalderon carolinaecalderon merged commit 225848a into main Nov 4, 2024
84 of 96 checks passed
@carolinaecalderon carolinaecalderon deleted the carolinac/deprecate-cherry-pick branch November 4, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants