Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: INFENG-943: GoReleaser configure prerelease #10146

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

davidfluck-hpe
Copy link
Contributor

Ticket

INFENG-943

Description

Set prerelease: auto in both Helm GoReleaser configs. GoReleaser will make intelligent decisions based on the tag and avoid setting release candidate Helm chart releases as "latest".

I'm not sure how this plays with the make_latest option, which also exists and is set to true by default, but marking a release as a pre-release (in GitHub) also turns off the "latest" flag, so I guess we'll see.

Test Plan

We'll have to do it live.

Checklist

  • Changes have been manually QA'd
  • New features have been approved by the corresponding PM
  • User-facing API changes have the "User-facing API Change" label
  • Release notes have been added as a separate file under docs/release-notes/
    See Release Note for details.
  • Licenses have been included for new code which was copied and/or modified from any external code

make intelligent decisions based on the tag and avoid setting release
candidate Helm chart releases as "latest".
Copy link

netlify bot commented Oct 28, 2024

Deploy Preview for determined-ui canceled.

Name Link
🔨 Latest commit cf1b0e8
🔍 Latest deploy log https://app.netlify.com/sites/determined-ui/deploys/67202347af40f600088095c3

@davidfluck-hpe davidfluck-hpe changed the title INFENG-943: GoReleaser configure prerelease build: INFENG-943: GoReleaser configure prerelease Oct 28, 2024
Copy link

codecov bot commented Oct 29, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.25%. Comparing base (5ea169c) to head (cf1b0e8).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10146      +/-   ##
==========================================
- Coverage   54.27%   54.25%   -0.03%     
==========================================
  Files        1259     1259              
  Lines      157257   157257              
  Branches     3642     3642              
==========================================
- Hits        85355    85314      -41     
- Misses      71769    71810      +41     
  Partials      133      133              
Flag Coverage Δ
backend 45.87% <ø> (-0.08%) ⬇️
harness 71.15% <ø> (ø)
web 54.29% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 6 files with indirect coverage changes

@davidfluck-hpe davidfluck-hpe merged commit 983a8ab into main Oct 29, 2024
86 of 99 checks passed
@davidfluck-hpe davidfluck-hpe deleted the INFENG-943-goreleaser-prerelease branch October 29, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant