-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add config policies to CLI reference docs #10118
Conversation
✅ Deploy Preview for determined-ui canceled.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10118 +/- ##
==========================================
- Coverage 54.49% 54.47% -0.03%
==========================================
Files 1267 1267
Lines 159437 159437
Branches 3637 3635 -2
==========================================
- Hits 86885 86850 -35
- Misses 72419 72454 +35
Partials 133 133
Flags with carried forward coverage won't be shown. Click here to find out more.
|
c301624
to
b6b345f
Compare
ddf59d4
to
0d464fe
Compare
Admins are encouraged to draft and save their config policies for each scope in separate YAML or | ||
JSON files. This allows for consistency between config policies set in the WebUI and CLI and | ||
lessens the chance for unintended changes to be made to a given scope's policies. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Order is good.
I don't agree with the reasons for the suggestion though. The config policies will be consistent if set via webUI or CLI whether admins draft them separately or not. That makes it sound like there's a bug in our APIs or something.
I think the reason to suggest admins draft it separately is that our webUI does not support common helpful features like "save", "undo", or any kind of history.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The config policies will be consistent if set via webUI or CLI whether admins draft them separately or not. That makes it sound like there's a bug in our APIs or something.
Hmm, I guess I meant consistency on their end (so that they don't have one config used for the webUI policies and a different folder of configs whose paths are input into the CLI).
but that makes sense! I'll rephrase the benefits of the note
0d464fe
to
81c481a
Compare
59c8e63
to
5ecf41b
Compare
5ecf41b
to
a5d296c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice
Ticket
CM-480
Description
det config-policies
shorthand namedet cp
--workspace-name
flag is unspecifiedTest Plan
Checklist
docs/release-notes/
See Release Note for details.